Minnigin Posted November 26, 2021 Report Share Posted November 26, 2021 (edited) checking several times a day for the update, the mixing bowl only crashes sometimes for me, I just save quick before using it now edit, forgot this Running on 64 bit Windows with 32 GB RAM Version: v1.15.9 (Stable)2021-11-26 7:27:43 AM: Critical error occurred System.InvalidOperationException: Collection was modified; enumeration operation may not execute. at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource) at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext() at Vintagestory.API.Client.GuiDialog.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.GuiManager.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.ClientMain.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.ClientPlatformWindows.Mouse_ButtonUp(Object sender, MouseButtonEventArgs e) at System.EventHandler`1.Invoke(Object sender, TEventArgs e) at System.EventHandler`1.Invoke(Object sender, TEventArgs e) at OpenTK.Platform.Windows.WinGLNative.WindowProcedure(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) at OpenTK.Platform.Windows.Functions.DispatchMessage(MSG& msg) at OpenTK.Platform.Windows.WinGLNative.ProcessEvents() at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) at _M48MnHH5BAvHUzcYoEuchRW0acb._e0atQ8VmmvgBK7zb3Yh4iDqOiHY(_UGHNIsOGTJBe1BTRXYmLwHTbmS , String[] ) at _xNqQDGqRsRSMIeuzt2MHKQHDzSd._e0atQ8VmmvgBK7zb3Yh4iDqOiHY(ThreadStart ) Edited November 26, 2021 by Minnigin Link to comment Share on other sites More sharing options...
ScarletDulcinea Posted November 26, 2021 Report Share Posted November 26, 2021 Alas another mixing bowl crash. Running on 64 bit Windows with 8 GB RAM Version: v1.15.9 (Stable)26/11/2021 12:17:55: Critical error occurred System.InvalidOperationException: Collection was modified; enumeration operation may not execute. at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource) at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext() at Vintagestory.API.Client.GuiDialog.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.GuiManager.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.ClientMain.OnMouseUp(MouseEvent args) at Vintagestory.Client.NoObf.ClientPlatformWindows.Mouse_ButtonUp(Object sender, MouseButtonEventArgs e) at System.EventHandler`1.Invoke(Object sender, TEventArgs e) at System.EventHandler`1.Invoke(Object sender, TEventArgs e) at OpenTK.Platform.Windows.WinGLNative.WindowProcedure(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) at OpenTK.Platform.Windows.Functions.DispatchMessage(MSG& msg) at OpenTK.Platform.Windows.WinGLNative.ProcessEvents() at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) at _M48MnHH5BAvHUzcYoEuchRW0acb._e0atQ8VmmvgBK7zb3Yh4iDqOiHY(_UGHNIsOGTJBe1BTRXYmLwHTbmS , String[] ) at _xNqQDGqRsRSMIeuzt2MHKQHDzSd._e0atQ8VmmvgBK7zb3Yh4iDqOiHY(ThreadStart ) ------------------------------- Link to comment Share on other sites More sharing options...
Hells Razer Posted November 26, 2021 Report Share Posted November 26, 2021 10 hours ago, Minnigin said: checking several times a day for the update, the mixing bowl only crashes sometimes for me, I just save quick before using it now As I posted earlier: On 11/17/2021 at 4:26 PM, Hells Razer said: Details: it happened when quickly clicking multiple times with the bucket. It did NOT happen after I reloaded and clicked with the water bucket in a more controlled way, until I started rapidly clicking with it for the second batch. Also just to be thorough tried it with the industrial one, same result. If you do not rapidly click multiple times when placing things in the mixing bowl it will not crash. Link to comment Share on other sites More sharing options...
Minnigin Posted November 26, 2021 Report Share Posted November 26, 2021 3 hours ago, Hells Razer said: As I posted earlier: If you do not rapidly click multiple times when placing things in the mixing bowl it will not crash. ahh okay, thanks. My bad, I didn't read back enough to see that. Link to comment Share on other sites More sharing options...
W0ND3R14ND Posted November 26, 2021 Report Share Posted November 26, 2021 4 hours ago, Hells Razer said: As I posted earlier: If you do not rapidly click multiple times when placing things in the mixing bowl it will not crash. It crashes for me even if I click slowly :/ Link to comment Share on other sites More sharing options...
Krystal Dragonness Posted November 29, 2021 Report Share Posted November 29, 2021 (edited) Reporting in to state the mixing bowl also makes me crash. I put a single piece of dough inside and boom, game death. Edited November 29, 2021 by Krystal Dragonness Link to comment Share on other sites More sharing options...
l33tmaan Posted December 2, 2021 Author Report Share Posted December 2, 2021 It's coming... 2 3 1 Link to comment Share on other sites More sharing options...
Conquest of Blocks Posted December 2, 2021 Report Share Posted December 2, 2021 when i do /debug logticks on my server, i often get gmleExpandedFoods.BlockEntityMixingBowl: X ms. So that means that this task seems to be pretty heavy on performance. Any way to tweak this, so that it will become more performance friendly? Link to comment Share on other sites More sharing options...
l33tmaan Posted December 2, 2021 Author Report Share Posted December 2, 2021 2 hours ago, CoB_Kai said: when i do /debug logticks on my server, i often get gmleExpandedFoods.BlockEntityMixingBowl: X ms. So that means that this task seems to be pretty heavy on performance. Any way to tweak this, so that it will become more performance friendly? Not that I'm aware of, since Jakecool's the one who tackled that. Of course, I am open to suggestions and/or direct assistance. Link to comment Share on other sites More sharing options...
l33tmaan Posted December 2, 2021 Author Report Share Posted December 2, 2021 Try slipping this to someone and hoping they don't look too closely at it... 1 1 Link to comment Share on other sites More sharing options...
Anabella Posted December 3, 2021 Report Share Posted December 3, 2021 (edited) Also having issues with the mixing bowl. In single player and place in rye flour then click in water and game crashes. Game version 1.15.9, mod version 1.4.4 Edited December 3, 2021 by Anabella Link to comment Share on other sites More sharing options...
Инга Рыжова Posted December 3, 2021 Report Share Posted December 3, 2021 Assumption. The mixing bowl gives an error when counting ingredients and choosing a recipe from what has been added. I noticed that the error occurs after the name of the dish is displayed in the bowl and then a new ingredient or quantity is added to the already added ingredient. I added 6 flour, 6 eggs and water. Water is added per liter and each time the ingredients are counted at the mixing bowl. Then I added all the ingredients 1 at a time. There was no crash when making 38 servings. The error is stably reproduced when adding any ingredient in a few clicks (as in the case of water, it is also reproduced in the case of honey) Link to comment Share on other sites More sharing options...
l33tmaan Posted December 3, 2021 Author Report Share Posted December 3, 2021 I haven't been getting the error in my testing lately, so I think it may be fixed... Link to comment Share on other sites More sharing options...
l33tmaan Posted December 4, 2021 Author Report Share Posted December 4, 2021 We're sitting at over 5000 recipes added now, and that's just for the mixing bowl. I shudder to think of how many combinations this actually entails, since a lot of the recipes use wildcards... 1 Link to comment Share on other sites More sharing options...
Pamela Posted December 4, 2021 Report Share Posted December 4, 2021 (edited) On 12/3/2021 at 8:43 AM, Инга Рыжова said: Assumption. The mixing bowl gives an error when counting ingredients and choosing a recipe from what has been added. I noticed that the error occurs after the name of the dish is displayed in the bowl and then a new ingredient or quantity is added to the already added ingredient. I added 6 flour, 6 eggs and water. Water is added per liter and each time the ingredients are counted at the mixing bowl. Then I added all the ingredients 1 at a time. There was no crash when making 38 servings. The error is stably reproduced when adding any ingredient in a few clicks (as in the case of water, it is also reproduced in the case of honey) So, we can load more than 6 of an item at a time now??? Edited December 4, 2021 by Pamela Wild Link to comment Share on other sites More sharing options...
Krystal Dragonness Posted December 5, 2021 Report Share Posted December 5, 2021 On 12/3/2021 at 9:56 AM, l33tmaan said: I haven't been getting the error in my testing lately, so I think it may be fixed... I just tested the mixing bowl in a creative world and found that it is still causing my game to crash. Here is a pastebin log of the crash this time instead of me just saying that I get the error too. For everyone else, this test was done with a single piece of dough with the intent of making berry bread. One dough, no quick clicking. Once the dough is in the bowl, crash.https://pastebin.com/1KY609gc Link to comment Share on other sites More sharing options...
Conquest of Blocks Posted December 8, 2021 Report Share Posted December 8, 2021 (edited) The mixing bowl is definitively a troublemaker. All my players are crashing a lot while using it. And as i mentioned before, its also slowing the server down, because ticks are taking too long. Check for yourself with /debug logticks. Needs to get fixed. @l33tmaan Talk to Jakecool please. My server is on 1.15.10 Edited December 8, 2021 by CoB_Kai Link to comment Share on other sites More sharing options...
l33tmaan Posted December 8, 2021 Author Report Share Posted December 8, 2021 I haven't had any mixing bowl crashes in my testing since making a small code change, so I think it's fixed now. 1.5.0 should resolve the crashing. The slowdown, though... that's going to take some digging. 1 Link to comment Share on other sites More sharing options...
l33tmaan Posted December 8, 2021 Author Report Share Posted December 8, 2021 I just have to wrap up the new crab & snake meat in Primitive Survival and update the handbook before 1.5.0 will be out. It won't be much longer. 1 Link to comment Share on other sites More sharing options...
Reikland Posted December 9, 2021 Report Share Posted December 9, 2021 Does it works in 1.5.9 / 10 ? Great work! Looks awesome Link to comment Share on other sites More sharing options...
l33tmaan Posted December 9, 2021 Author Report Share Posted December 9, 2021 (edited) 18 minutes ago, Reiland said: Does it works in 1.5.9 / 10 ? Great work! Looks awesome So far so good, yeah! Edited December 9, 2021 by l33tmaan 1 Link to comment Share on other sites More sharing options...
l33tmaan Posted December 10, 2021 Author Report Share Posted December 10, 2021 (edited) I'll post updates a little more quickly since we're nearing release... Edited December 10, 2021 by l33tmaan Link to comment Share on other sites More sharing options...
l33tmaan Posted December 10, 2021 Author Report Share Posted December 10, 2021 (edited) PRIMITIVE SURVIVAL COMPATIBILITY HAS BEEN COMPLETED! NO MIXING BOWL ERRORS ENCOUNTERED IN HOURS! TIME TO WRAP THINGS UP AND GET 1.5.0 OUT THE DOOR! Edited December 11, 2021 by l33tmaan 2 1 2 Link to comment Share on other sites More sharing options...
l33tmaan Posted December 12, 2021 Author Report Share Posted December 12, 2021 I've been handing a lot of stuff behind the scenes to make the various logs happier when you don't have certain combinations of mods. Turns out Acorns and Primitive Survival are a little more ingrained than I thought. However, I have finished updating the handbook and I just need to clean up these logs and do a final test to make sure everything's working. The update is DEFINITELY coming out this week! 1 Link to comment Share on other sites More sharing options...
Pamela Posted December 12, 2021 Report Share Posted December 12, 2021 2 hours ago, l33tmaan said: I've been handing a lot of stuff behind the scenes to make the various logs happier when you don't have certain combinations of mods. Turns out Acorns and Primitive Survival are a little more ingrained than I thought. However, I have finished updating the handbook and I just need to clean up these logs and do a final test to make sure everything's working. The update is DEFINITELY coming out this week! Will the update work backwards, i.e. on version 1.15.5?? Link to comment Share on other sites More sharing options...
Recommended Posts